Added rtmps protocol on client connection #65
Merged
+17
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim here is to support
rtmps
protocol with the library (rtmp using a TLS connection). No special modification is needed on the server side because we can already provide anet.Listener
which could use TLS or not, but on the client side anet.Dialer
is used preventing from using TLS.So I added a new method
TLSDial
to support this case even if it not perfect. I could have re-used the already existingDial
method to support bothrtmp
andrtmps
but the problem is that I need to provide an extra configurationtls.Config
to make it work. Another possibility would be to put this config directly in thertmp.ConnConfig
but the problem is that it is used for both the client & server connection, and it would only be necessary for a client connection. I can update my PR if you think it is a better approach or if you see another one ?I also removed the function
makeValidAddr
because it is not used but I can put it back if you think it is needed